feat(evm/cheatcodes): Use alloy-signer, rm ethers-signers/ethers-core
#6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jan 26, 2024
Comment on lines
+158
to
+162
| // The `ecrecover` precompile does not use EIP-155. No chain ID is needed. | ||
| let wallet = parse_wallet(private_key)?; | ||
|
|
||
| // The `ecrecover` precompile does not use EIP-155 | ||
| let sig = wallet.sign_hash(digest.to_ethers())?; | ||
| let recovered = sig.recover(digest.to_ethers())?.to_alloy(); | ||
| let sig = wallet.sign_hash_sync(*digest)?; | ||
| let recovered = sig.recover_address_from_prehash(digest)?; |
There was a problem hiding this comment.
so the previous impl also didn't require the chain id?
DaniPopes
reviewed
Jan 26, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Jan 26, 2024
| "alloy-sol-types", | ||
| "base64 0.21.7", | ||
| "const-hex", | ||
| "ethers-core", | ||
| "ethers-signers", |
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were still using ethers for signers on cheatcodes.
Solution
Replaces ethers-signers with alloy signers, and removes the now unused ethers deps from
cheatcodes.This isolates signers on
forge script/cast, in which we're still converting to ethers signers.