foundry: vm.dumpState skips empty accounts
#6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `vm.dumpState` to also skip empty accounts. Empty accounts are not particularly useful and would otherwise require a postprocessing step after the state dump to remove. Adds a unit test showing that it works and updates an old unit test as an empty account is defined by a nonce of 0, no balance and no code. If there is storage, it still counts as an empty account. cargo fmt
tynes
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 2, 2024
Updates foundry to the latest nightly release. https://github.com/foundry-rs/foundry/releases/tag/nightly-84d98427e17370ff08ec34f00e3c7e539753a760 It includes foundry-rs/foundry#6986 which will help to make L2 genesis generation much more simple. Reminder that we must always do releases of `ci-builder` using a nightly foundry release that has not yet been pruned from github. When building from source in `ci-builder`, there are issues at runtime. When downloading the binary from github, there are no issues. Will follow up with a release of `ci-builder` and then update the version of `ci-builder` used in CI.
github-merge-queue bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 2, 2024
Updates foundry to the latest nightly release. https://github.com/foundry-rs/foundry/releases/tag/nightly-84d98427e17370ff08ec34f00e3c7e539753a760 It includes foundry-rs/foundry#6986 which will help to make L2 genesis generation much more simple. Reminder that we must always do releases of `ci-builder` using a nightly foundry release that has not yet been pruned from github. When building from source in `ci-builder`, there are issues at runtime. When downloading the binary from github, there are no issues. Will follow up with a release of `ci-builder` and then update the version of `ci-builder` used in CI.
RPate97
pushed a commit
to RPate97/foundry
that referenced
this pull request
Feb 3, 2024
* foundry: `vm.dumpState` skips empty accounts Update `vm.dumpState` to also skip empty accounts. Empty accounts are not particularly useful and would otherwise require a postprocessing step after the state dump to remove. Adds a unit test showing that it works and updates an old unit test as an empty account is defined by a nonce of 0, no balance and no code. If there is storage, it still counts as an empty account. cargo fmt * testdata: cleanup
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
vm.dumpStatecurrently includes empty accounts which isn't particularly usefulSolution
Update
vm.dumpStateto also skip empty accounts. Empty accounts are not particularly useful and would otherwise require a postprocessing step after the state dump to remove.Adds a unit test showing that it works and updates an old unit test as an empty account is defined by a nonce of 0, no balance and no code. If there is storage, it still counts as an empty account.