-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cheatcode) Add cheatcode to set block.blobbasefee #7005
feat(cheatcode) Add cheatcode to set block.blobbasefee #7005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not generated on my file, should i run a command to generate it or something? Edit: just read that cargo cheats do that |
this should be on this pr or seperate pr ? |
@mattsse does it look better to you ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! as @mattsse mentioned, we need a getBlobBaseFee
too, since solc sometimes optimizes away certain reads on block
, so we (unfortunately) have to add getter cheatcodes too.
@yash-atreya could you please bring this over the line, I think this is almost done |
hey! I got it here #7598! |
Closing since this has already been merged per above |
related with #7002
is there a way to automatically generate what should be in thecrates/cheatcodes/assets/cheatcodes.json or i have to write ths myself?