Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cheatcode) Add cheatcode to set block.blobbasefee #7005

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Feb 2, 2024

related with #7002

is there a way to automatically generate what should be in thecrates/cheatcodes/assets/cheatcodes.json or i have to write ths myself?

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vm.sol updates are generated

we also want a vm.getBlobBasefee

FYI @onbjerg

crates/cheatcodes/src/evm.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Feb 3, 2024

vm.sol updates are generated

it's not generated on my file, should i run a command to generate it or something?

Edit: just read that cargo cheats do that

@DoTheBestToGetTheBest
Copy link
Contributor Author

we also want a vm.getBlobBasefee

this should be on this pr or seperate pr ?

@DoTheBestToGetTheBest
Copy link
Contributor Author

@mattsse does it look better to you ?

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! as @mattsse mentioned, we need a getBlobBaseFee too, since solc sometimes optimizes away certain reads on block, so we (unfortunately) have to add getter cheatcodes too.

@mattsse
Copy link
Member

mattsse commented Apr 4, 2024

@yash-atreya could you please bring this over the line, I think this is almost done

@kamuik16
Copy link
Contributor

kamuik16 commented Apr 8, 2024

@yash-atreya could you please bring this over the line, I think this is almost done

hey! I got it here #7598!

@onbjerg
Copy link
Member

onbjerg commented Apr 17, 2024

Closing since this has already been merged per above

@onbjerg onbjerg closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants