-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forge): blobbasefee cheatcode #7598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! needs forge fmt + nit. tests need to be run using the cancun test profile
ran the test with cancun evm version but did not push into the pr. |
Hey @kamuik16, let me know if you need help with anything |
I am waiting for reviews. I think it's done from my side. Working correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah this is now a cheat that only works with CANCUN, hence the failing test.
so what we need now is a test, just like:
https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/cheats.rs#L10-L26
but uses
https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/test_helpers.rs#L273-L275
and we need a cancun/cheats folder not default/cheats
TODO
- create cancun/cheats folder and move test
- add a new rust test similar to cheats that uses the
TEST_DATA_CANCUN
config
hey @mattsse! I moved the test into cancun folder and ci is passing but struggling with the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks for the test help! |
Closes #7002