Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): fix debugger out-of-range panic #7059

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

emo-eth
Copy link
Contributor

@emo-eth emo-eth commented Feb 9, 2024

Motivation

The debugger sometimes panics with an out-of-range error when slicing an array.

Solution

Reproduction is tricky because the error depends on the height of the debugger window.

Ensure that start_line is always strictly less than before.len().

Closes #7029

@onbjerg onbjerg added the T-bug Type: bug label Feb 9, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse merged commit 52794a3 into foundry-rs:master Feb 9, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger panics due to out-of-bounds access during debugging session
3 participants