chore(deps): remove build-time dependency on libgit2 #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/drop-git2
branch
from
cd3b9df
to
b8e3476
Compare
DaniPopes
force-pushed
the
dani/drop-git2
branch
from
b8e3476
to
272146d
Compare
DaniPopes
added a commit
to paradigmxyz/reth
that referenced
this pull request
Feb 10, 2024
Every user who builds Foundry from source has git installed. Use the `"gitcl"` feature to make `vergen` use the `git` binary in the `PATH` instead of depending on `libgit2`. Same as foundry-rs/foundry#7078
DaniPopes
added a commit
to paradigmxyz/reth
that referenced
this pull request
Feb 10, 2024
Every user who builds Foundry from source has git installed. Use the `"gitcl"` feature to make `vergen` use the `git` binary in the `PATH` instead of depending on `libgit2`. Same as foundry-rs/foundry#7078
DaniPopes
added a commit
to paradigmxyz/reth
that referenced
this pull request
Feb 10, 2024
Every user who builds from source has git installed. Use the `"gitcl"` feature to make `vergen` use the `git` binary in the `PATH` instead of depending on `libgit2`. Same as foundry-rs/foundry#7078
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Every user who builds Foundry from source has git installed.
Solution
Use the
"gitcl"feature to makevergenuse thegitbinary in thePATHinstead of depending onlibgit2.