#6616: createSelectFork does not fork latest block number if you sleep #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk id (url@latest_block). if block provided then fork id is url@provided_block (this means there'll no longer be a url@latest fork id but always url@block) - after creation of fork the id is checked if in inserted forks. If it doesn't exist then it's inserted, otherwise the existing backend is reused and a new fork url@latest_block-1 recorded CreatedFork::inc_senders increments number of senders and returns the new unique fork id. CreatedFork::num_senders was removed MultiForkHandler::insert_new_fork added to handle fork insertion / send on channels
2 tasks
grandizzy
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
mattsse
approved these changes
Feb 19, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6616
proposed solution for solving #6616, slightly different than suggested #6616 (comment) (in the sense that
url@latestfork id was made obsolete and insteadurl@latest_blockis recorded)Motivation
Solution
if no block provided then fork is created using latest block for fork id (
url@latest_block). if block provided then fork id is url@provided_block (this means there'll no longer be aurl@latestfork id but alwaysurl@block)after creation of fork the id is checked if in inserted forks. If it doesn't exist then it's inserted, otherwise the existing backend is reused and a new fork
url@latest_block-1recordedchanged
CreatedFork::inc_sendersto increment number of senders and return the new unique fork id.CreatedFork::num_senderswas removedMultiForkHandler::insert_new_forkadded to handle fork insertion / send on channelsadded Issue6616Test to cover scenario, looping for 50 seconds should suffice with the current average block time of 12