-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve LocalTraceIdentifier performance #7118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation modified from #7105, see that PR for more information. Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
klkvr
reviewed
Feb 14, 2024
klkvr
approved these changes
Feb 14, 2024
Updated to start searching at equal code length for the super majority case because otherwise we're searching |
DaniPopes
force-pushed
the
dani/perf-localidentifier
branch
from
February 14, 2024 05:13
377a75c
to
0e466ca
Compare
mattsse
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff score 👍
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we still want this. cc @klkvr
Implementation modified from #7105,
see that PR for more information.
I modified it to use binary search on the sorted id array to find the minimum index, then iterating starting from that point instead of filtering which would search the entire array.
See main thread performance in the following profiles: