feat: add a revert decoder to eagerly hash error selectors #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eagerly hash selectors once instead of on every call to
decode_revert. This improves performance when decoding lots of traces with lots of contracts as decoding custom errors is now trivial.Diff is kinda bad but the decoding logic is unchanged (review with "hide whitespace").
Closes #7119
See
render_trace_arena, from ~2000 to ~750 samples for the same task (FOUNDRY_PROFILE=lite forge t -vvvvv --nmc Forkin sablier/v2-core):