issue 6319: copy raw sliced value as tail in new value to be converted #7194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
Evalir and
mattsse
as code owners
mattsse
requested changes
Feb 20, 2024
yeah, was thinking to do this but command requires an etherscan key and I don't think is OK to use the provided one? |
|
can use this one JQNGFHINKS1W7Y5FRXU4SPBYF43J3NYK46 |
great, added with 649f5d9 |
mattsse
approved these changes
Feb 21, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
additional fix for #6319
tested with #6319 (comment) not sure though how to add a unit test for it, please advise
Solution