feat(anvil): add support for EIP4844 types
#7202
Conversation
Evalir
force-pushed
the
evalir/add-4844-types
branch
from
39f2a56
to
85ca342
Compare
Evalir
changed the title
anvil): add support for EIP4844 typesanvil): add support for EIP4844 types
| @@ -259,6 +259,12 @@ impl FeeHistoryService { | |||
| .min(U256::from(t.max_fee_per_gas).saturating_sub(base_fee)) | |||
| .to::<u64>() | |||
| } | |||
| // TODO: This probably needs to be extended to extract 4844 info. | |||
There was a problem hiding this comment.
Will be done in a subsequent PR which modifies FeeHistory to accomodate 4844 changes
There was a problem hiding this comment.
we should add a follow up issue for this to track
There was a problem hiding this comment.
This should go on #7242
There was a problem hiding this comment.
this does not support the envoloped format for 4844 which includes the sidecar
I think we want a helper type here that decodes with the sidecar, then extract the sidecar (+ validate), and convert into TypedTx
https://github.com/foundry-rs/foundry/blob/master/crates/anvil/src/eth/api.rs#L942-L942
| @@ -259,6 +259,12 @@ impl FeeHistoryService { | |||
| .min(U256::from(t.max_fee_per_gas).saturating_sub(base_fee)) | |||
| .to::<u64>() | |||
| } | |||
| // TODO: This probably needs to be extended to extract 4844 info. | |||
There was a problem hiding this comment.
we should add a follow up issue for this to track
| @@ -39,11 +42,14 @@ pub fn transaction_request_to_typed(tx: TransactionRequest) -> Option<TypedTrans | |||
| gas_price, | |||
| max_fee_per_gas, | |||
| max_priority_fee_per_gas, | |||
| max_fee_per_blob_gas, | |||
There was a problem hiding this comment.
I forget, why don't we do this with a From impl / reuse any alloy types code? Is it due to the Deposit tx I guess?
There was a problem hiding this comment.
nit there's a Some(126) below i'd like to replace it with a const that indicates the semantic value of the number from op specs
| /// EIP-4844 transaction | ||
| EIP4844(Signed<TxEip4844Variant>), | ||
| /// op-stack deposit transaction | ||
| Deposit(DepositTransaction), |
There was a problem hiding this comment.
same here i take that we redefine the enum vs reusing from alloy bc of the deposit tx right?
@mattsse do u have any ideas for doing this with a super-enum?
something like enum TypedTransaction { #[flatten] Inner(alloy::TypedTransaction), Deposit(...)?
| @@ -259,6 +259,12 @@ impl FeeHistoryService { | |||
| .min(U256::from(t.max_fee_per_gas).saturating_sub(base_fee)) | |||
| .to::<u64>() | |||
| } | |||
| // TODO: This probably needs to be extended to extract 4844 info. | |||
Motivation
This does not include any functionality regarding 4844 yet other than support for 4844 variants in the corresponding types.
First of a series of PRs that will add Cancun support to foundry. Tracking here: #5574
Solution
Add support for 4844 transaction types.