feat: Add call depth to vm.stopAndReturnStateDiff() results
#7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPate97
force-pushed
the
pate/issue-6632
branch
from
88ce027
to
3035ae9
Compare
RPate97
force-pushed
the
pate/issue-6632
branch
4 times, most recently
from
36d4c64
to
a6a9e29
Compare
RPate97
commented
Feb 25, 2024
Comment on lines
-86
to
-92
| #[derive(Clone, Debug)] | ||
| pub struct AccountAccess { | ||
| /// The account access. | ||
| pub access: crate::Vm::AccountAccess, | ||
| /// The call depth the account was accessed. | ||
| pub depth: u64, | ||
| } |
There was a problem hiding this comment.
I've removed this wrapper type. It's unnecessary since depth is now a field on the underlying AccountAccess type. I'm happy to reverse this change if there are plans to use this wrapper for some other purpose, but it seems redundant to me.
RPate97
force-pushed
the
pate/issue-6632
branch
from
a6a9e29
to
24903c2
Compare
mattsse
approved these changes
Feb 26, 2024
DaniPopes
approved these changes
Feb 26, 2024
|
FYI I've edited the description to use GitHub keywords when referencing issues. |
Yeah, I believe so. Is there a contributor guide I can reference for that? |
|
There is no need, this will get included in the next release automatically. |
zeroXbrock
pushed a commit
to flashbots/suavex-foundry
that referenced
this pull request
Apr 2, 2024
…y-rs#7234) * Added depth member to AccountAccess * Combine AccountAccess structs --------- Co-authored-by: ercembu <ercembulut@gmail.com>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #6632
Solution
The call depth was already recorded in the
cheatcodes::inspector::AccountAccesswrapper. This PR removes that wrapper type in favor of only usingcheatcodes::vm::AccountAccess, which now has a depth field.Credit to ercembu in #6667 for the initial implementation. I decided to pick this up since it's important to us at Sphinx, and that PR appears to be abandoned. I recommend closing that once this is merged.