invariant (bug): inconsistent shrinked call sequence sometimes #7256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
while testing fix for #5868 noticed that sometimes the shrinked sequence comes inverted, e.g.
instead
this happens when the same
acceptOwnership
call that breaks invariant is also performed beforetransferOwnership
prereq, that is in a sequence of:acceptOwnership
and revertstransferOwnership
to AliceacceptOwnership
and breaks invariantin this case shrinked indices are [2, 1] but we recreate call sequence as 1 and 2
Solution
Recreate new shrinked call sequence by respecting the order from shrunk call indices