Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore forge-std artifacts in build --sizes #7414

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: ignore forge-std artifacts in build --sizes #7414

merged 1 commit into from
Mar 18, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Mar 16, 2024 •
edited
Loading

ref foundry-rs/forge-std#522
ref foundry-rs/forge-std#523

ignores all forge-std artifacts when --build --sizes

@mattsse mattsse requested a review from DaniPopes as a code owner March 16, 2024 12:55
@mattsse mattsse requested a review from klkvr March 16, 2024 13:14
klkvr
klkvr approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@klkvr klkvr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wondering if the expected behavior is to just display sizes only for contracts under src? We will miss data for contracts from libraries, but not sure if its really useful in most of the cases

@mattsse
Copy link
Member Author

mattsse commented Mar 18, 2024

We will miss data for contracts from libraries, but not sure if its really useful in most of the cases

I believe those will be picked up again after the forge-std, this only excludes all artifacts from forge-std itself

@mattsse mattsse merged commit a08a7da into foundry-rs:master Mar 18, 2024
18 of 19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @klkvr