chore: fix test project initialization #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Mar 17, 2024
onbjerg
approved these changes
Mar 17, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI for #7415 failed with this error again, it seems that the issue in fact is happening because process initializing template might fail, but will write "1" to lock file anyway: https://github.com/foundry-rs/foundry/actions/runs/8315673331/job/22754269551#step:12:127 - here it failed while running
forge buildwith "Text file busy (os error 26)", not sure why exactly.We should only write "1" to lockfile after we've successfuly copied template to its location, thus this PR just changes order of things.