Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Instruction enum in debug steps #7464

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

DaniPopes
Copy link
Member

I don't find this particularly useful and it complicates any potential upstreaming or code anywhere else

@DaniPopes DaniPopes requested a review from mattsse as a code owner March 21, 2024 07:06
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@DaniPopes DaniPopes requested a review from onbjerg March 21, 2024 11:55
@DaniPopes DaniPopes merged commit 5ecc1bf into master Mar 22, 2024
19 checks passed
@DaniPopes DaniPopes deleted the dani/rm-instruction branch March 22, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants