Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): Add memery limit to anvil node #7482

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Mar 25, 2024

Currently anvil can running into error "EVM error MemoryLimitOOG" closes #7478

We add here a way to custom the memory limit for anvil node.

The default assigned here is 100 and can be changed if it's not the right default number.

EDIT: changed default value for memory-limit to 10000 after seeing all test related to anvil failling

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

we shouldn't introduce new constants and instead use the revm defaults

crates/anvil/src/config.rs Outdated Show resolved Hide resolved
crates/anvil/src/config.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

great.

we shouldn't introduce new constants and instead use the revm defaults

ty very much for you review, does changes looks better for you ?

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/anvil/src/config.rs Outdated Show resolved Hide resolved
@mattsse mattsse merged commit bf5bfe0 into foundry-rs:master Mar 25, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anvil: configure memory limit
2 participants