Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cast): pretty print tx status in cast receipt #7534

Merged
merged 3 commits into from
Apr 9, 2024
Merged

feat(cast): pretty print tx status in cast receipt #7534

merged 3 commits into from
Apr 9, 2024

Conversation

llllvvuu
Copy link
Contributor

@llllvvuu llllvvuu commented Apr 1, 2024

Motivation

status                  0

easy to miss

Solution

status                  0 (failed)

stands out

mattsse
mattsse reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klkvr this will conflict with #7106

so I'll keep this open and we can reapply that change

mattsse
mattsse approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 7bb2b20 into foundry-rs:master Apr 9, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llllvvuu @mattsse