feat: optimize compilation by reading AST #7599
Conversation
crates/common/src/compile.rs
Outdated
| for file in graph.files().keys() { | ||
| let src = std::fs::read_to_string(file)?; | ||
| let (parsed, _) = solang_parser::parse(&src, 0) | ||
| .map_err(|_| eyre::eyre!("Failed to parse {}.", file.display()))?; |
There was a problem hiding this comment.
we now depend on solang to parse it successfully.
should we fallback to previous behaviour if this fails?
There was a problem hiding this comment.
yeah I think we can do that
actually thought that we assumed solang being able to parse any valid Solidity
perhaps its better to invoke solc with empty output instead? similar to how we do it for tests now requesting just abi
There was a problem hiding this comment.
actually thought that we assumed solang being able to parse any valid Solidity
it could be that future lang features are not supported right away, so I think we can fallback to previous behaviour if parsing fails.
if there's any syntax error this should also ensure that the user gets the proper solc error message
There was a problem hiding this comment.
updated code, now we fallback to running solc with empty output when solang fails
not really want to fully fallback to old behavior as this is not the most efficient way and will add additional complexity because we'd have to handle potential find_contract_path errors everywhere
klkvr
force-pushed
the
klkvr/smarter-compilation
branch
from
b17a4c6
to
c2cfc04
Compare
klkvr
force-pushed
the
klkvr/smarter-compilation
branch
from
df83444
to
ca60334
Compare
Motivation
Currently when running
forge script <contract_name>orforge script <contract_path>we will recompile entire project, this is true forforge createandforge selectorsas well.Solution
Use already existing files filter on
ProjectCompilerwhen path is provided, use solang AST to find source file when only contract name is provided.