Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coverage for modifiers #7669

Merged
merged 1 commit into from
Apr 16, 2024
Merged

feat: coverage for modifiers #7669

merged 1 commit into from
Apr 16, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Apr 15, 2024

Motivation

Closes #3489

Solution

Visit modifiers when collecting coverage items. I've excluded placeholder statements (_;) from coverage reports because they never get referenced in source maps thus we can't really provide any coverage info for them.

@klkvr klkvr requested a review from onbjerg as a code owner April 15, 2024 14:45
@DaniPopes DaniPopes merged commit 8466c09 into master Apr 16, 2024
19 checks passed
@DaniPopes DaniPopes deleted the klkvr/modifier-coverage branch April 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forge coverage for modifiers is missing/incomplete
2 participants