fix(traces): Etherscan traces are only resolved for first instance of test run #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
mattsse
requested changes
Apr 15, 2024
Comment on lines
123
to
138
| let resolved = resolved | ||
| .into_iter() | ||
| .map(|addr| { | ||
| let metadata = self.contracts.get(&addr).unwrap(); | ||
| let label = metadata.contract_name.clone(); | ||
| let abi = metadata.abi().ok().map(Cow::Owned); | ||
|
|
||
| AddressIdentity { | ||
| address: addr, | ||
| label: Some(label.clone()), | ||
| contract: Some(label), | ||
| abi, | ||
| artifact_id: None, | ||
| } | ||
| }) | ||
| .collect::<Vec<AddressIdentity<'_>>>(); |
There was a problem hiding this comment.
this can be done in the for loop above?
so that we track AddressIdentity in resolved?
mattsse
approved these changes
Apr 16, 2024
mattsse
deleted the
zerosnacks/fix-etherscan-traces-only-resolved-first-run
branch
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #7558
Currently the resolved Etherscan traces are only applied to the first occurrence of an address due to the resolved addresses not being captured and returned, see:
foundry/crates/evm/traces/src/identifier/etherscan.rs
Lines 114 to 118 in ee47bb0
Solution
Reproducible by running minimal repro: https://github.com/zerosnacks/foundry-repro-7558
Implementation is largely pragmatic, emphasis on minimal changes - open to feedback