Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always set optimizer details #7690

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: always set optimizer details #7690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions crates/config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,11 +1028,18 @@ impl Config {
}

/// Returns the `Optimizer` based on the configured settings
///
/// Note: optimizer details can be set independently of `enabled`
/// See also: <https://github.com/foundry-rs/foundry/issues/7689>
/// and <https://github.com/ethereum/solidity/blob/bbb7f58be026fdc51b0b4694a6f25c22a1425586/docs/using-the-compiler.rst?plain=1#L293-L294>
pub fn optimizer(&self) -> Optimizer {
// only configure optimizer settings if optimizer is enabled
let details = if self.optimizer { self.optimizer_details.clone() } else { None };

Optimizer { enabled: Some(self.optimizer), runs: Some(self.optimizer_runs), details }
Optimizer {
enabled: Some(self.optimizer),
runs: Some(self.optimizer_runs),
// we always set the details because `enabled` is effectively a specific details profile
// that can still be modified
details: self.optimizer_details.clone(),
}
}

/// returns the [`foundry_compilers::ConfigurableArtifacts`] for this config, that includes the
Expand Down
Loading