Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always set optimizer details #7690

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: always set optimizer details #7690

merged 1 commit into from
Apr 16, 2024

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Apr 16, 2024

reverts #4427

closes #7689

PR #4427 ignores optimizer_details if optimizer is disabled. However, optimizer = false doesn't completely disable optimizations, and in order to so additional optimizer details have to be provided.

@mattsse mattsse added the T-bug Type: bug label Apr 16, 2024
@mattsse mattsse requested a review from klkvr April 16, 2024 20:20
@DaniPopes DaniPopes merged commit 9079fb6 into foundry-rs:master Apr 16, 2024
19 checks passed
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizer details are ignored if optimizer is disabled
2 participants
@mattsse @DaniPopes