Edge controller: only define GCP credentials env var when secret exists #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what we do for the other charts as well, and makes it possible to use the edge controller from e.g minikube using CLI credentials in a testing context. This is convenient for development and for potential users who just want to kick the tires without provisioning service accounts.
foxglovenes
approved these changes
Sep 19, 2023
|
Do we still want this? Has it gone stale? |
|
Closing for inactivity. If we want this we can revisit - I've not heard complaints about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we do for the other charts as well, and makes it possible to use the edge controller from e.g minikube using CLI credentials in a testing context. This is convenient for development and for potential users who just want to kick the tires without provisioning service accounts.