Add explicit field IDs to flatbuffer schemas #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added explicit field IDs to flatbuffer schemas.
Docs
None
Description
This allows the schemas to be compiled with
--require-explicit-ids
turned on inflatc
, which can be nice to help prevent people from accidentally making breaking changes to flatbuffer schemas if they choose to reorder fields (or insert new fields in the middle of the schemas). Because of how flatc works with includes, if downstream users want to use--require-explicit-ids
on their own schemas that happen to include foxglove schema types, they must update the foxglove schemas that they use to include IDs.