Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ament #869

Closed
wants to merge 3 commits into from
Closed

Feature/ament #869

wants to merge 3 commits into from

Conversation

jlack1987
Copy link

Changelog

Add option to build as part of a ros2 workspace

Description

Add optional ament check so ros2 users can compile this within a ros2 workspace and depend on it that way.

@achim-k
Copy link
Collaborator

achim-k commented Nov 5, 2024

For ROS2 users, I would recommend to create a separate ws_protocol_vendor package (in another repo) which exposes the C++ & Python libs to ROS2 packages that depend on it. This would look very similar to mcap_vendor which uses fetchContent under the hood. We could then also use the ws_protocol_vendor package for foxglove/ros-foxglove-bridge#89

@achim-k achim-k closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants