Introduce ability to view resolved errors and delete them #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is lovely! Thank you. I'm presently quite busy, but I am trying to carve out time to properly review this and merge and release. But first pass looks good |
|
Thanks for the review! I have pushed a commit that I believe addresses all of your feedback. Additionally I have pushed a second commit that adds a toggle to the top right of the index page allowing you to switch between resolved and unresolved index views. Screenshot below.
|
|
Lovely. I want to make a few small tweaks. I'll try to carve out time next week. This is excellent tho. Thank you for this! |
Merged
|
Released with version 0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry it took so long to circle back around to this! Hopefully with the release of Rails 7.2, backporting a patch will no longer be needed to run this in prod.
This introduces a new collection route at
/errors/resolvedthat displays an index view of resolved errors.On the
showandindexviews, theResolve Errorbutton will be replaced with aDelete Errorbutton when showing resolved errors. The deletion action checks that the error is in fact resolved before proceeding with the deletion.In addition to the button, I added a small tag next to the error id on the
showpage indicating its status as eitheropenorresolvedso the user has a little more context when on a single error's page.In order to make this useful, we need some way of navigating to the resolved errors index page (and back). This could be tabs or simply a link or button somewhere. As there is currently no top-level navigation for the site, I wanted to check with you before unilaterally introducing something like that. Maybe just a link for now?
Screenshots
Error row appearance in resolved index view:
Show page for an error that has already been resolved:
closes #4