-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ability to view resolved errors and delete them #55
Conversation
This is lovely! Thank you. I'm presently quite busy, but I am trying to carve out time to properly review this and merge and release. But first pass looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts.
Lovely. I want to make a few small tweaks. I'll try to carve out time next week. This is excellent tho. Thank you for this! |
Released with version 0.5.0 |
Sorry it took so long to circle back around to this! Hopefully with the release of Rails 7.2, backporting a patch will no longer be needed to run this in prod.
This introduces a new collection route at
/errors/resolved
that displays an index view of resolved errors.On the
show
andindex
views, theResolve Error
button will be replaced with aDelete Error
button when showing resolved errors. The deletion action checks that the error is in fact resolved before proceeding with the deletion.In addition to the button, I added a small tag next to the error id on the
show
page indicating its status as eitheropen
orresolved
so the user has a little more context when on a single error's page.In order to make this useful, we need some way of navigating to the resolved errors index page (and back). This could be tabs or simply a link or button somewhere. As there is currently no top-level navigation for the site, I wanted to check with you before unilaterally introducing something like that. Maybe just a link for now?
Screenshots
Error row appearance in resolved index view:
Show page for an error that has already been resolved:
closes #4