Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved errors #56

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Resolved errors #56

merged 13 commits into from
Aug 22, 2024

Conversation

fractaledmind
Copy link
Owner

@fractaledmind fractaledmind commented Aug 22, 2024

@acoffman Here is my proposed version of #55.

The index view with the "Unresolved" tab selected looks like this:
CleanShot 2024-08-22 at 12 15 40@2x

The show view for an unresolved issue like this:
CleanShot 2024-08-22 at 12 15 56@2x

The index view with the "Resolved" tab selected looks like this:
CleanShot 2024-08-22 at 12 16 54@2x

and, the show view for a resolved issue like this:
CleanShot 2024-08-22 at 12 18 12@2x

WDYT?

@acoffman
Copy link
Contributor

Looks great overall!

If I'm reading the diff correctly, there a couple of dangling Tailwind classes that I introduced for the _nav partial that are no longer being used with your reworked version, they can be removed:

rounded-l-lg
rounded-r-lg
float-right

@fractaledmind fractaledmind merged commit a6e42ee into main Aug 22, 2024
4 checks passed
@fractaledmind fractaledmind deleted the resolved-errors branch August 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants