Skip to content

Commit

Permalink
chore: asset finance books validation (#36979)
Browse files Browse the repository at this point in the history
(cherry picked from commit 0077659)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.py
  • Loading branch information
anandbaburajan authored and mergify[bot] committed Sep 6, 2023
1 parent 3a71fa9 commit 046fe63
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions erpnext/assets/doctype/asset/asset.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ def validate(self):
self.validate_item()
self.validate_cost_center()
self.set_missing_values()
<<<<<<< HEAD
self.prepare_depreciation_data()
=======
self.validate_finance_books()
if not self.split_from:
self.prepare_depreciation_data()
update_draft_asset_depr_schedules(self)
>>>>>>> 0077659e93 (chore: asset finance books validation (#36979))
self.validate_gross_and_purchase_amount()
if self.get("schedules"):
self.validate_expected_value_after_useful_life()
Expand Down Expand Up @@ -197,6 +204,27 @@ def set_missing_values(self):
finance_books = get_item_details(self.item_code, self.asset_category)
self.set("finance_books", finance_books)

def validate_finance_books(self):
if not self.calculate_depreciation or len(self.finance_books) == 1:
return

finance_books = set()

for d in self.finance_books:
if d.finance_book in finance_books:
frappe.throw(
_("Row #{}: Please use a different Finance Book.").format(d.idx),
title=_("Duplicate Finance Book"),
)
else:
finance_books.add(d.finance_book)

if not d.finance_book:
frappe.throw(
_("Row #{}: Finance Book should not be empty since you're using multiple.").format(d.idx),
title=_("Missing Finance Book"),
)

def validate_asset_values(self):
if not self.asset_category:
self.asset_category = frappe.get_cached_value("Item", self.item_code, "asset_category")
Expand Down

0 comments on commit 046fe63

Please sign in to comment.