Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: asset finance books validation #36979

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: asset finance books validation #36979

merged 1 commit into from
Sep 6, 2023

Conversation

anandbaburajan
Copy link
Contributor

Now duplicate finance books won't be allowed and finance book field cannot be empty if multiple finance books are used.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #36979 (f5deb77) into develop (d2f03c8) will increase coverage by 0.00%.
Report is 5 commits behind head on develop.
The diff coverage is 81.81%.

@@           Coverage Diff            @@
##           develop   #36979   +/-   ##
========================================
  Coverage    65.55%   65.55%           
========================================
  Files          796      796           
  Lines        62719    62743   +24     
========================================
+ Hits         41115    41132   +17     
- Misses       21604    21611    +7     
Files Changed Coverage
erpnext/assets/doctype/asset/asset.py 81.81%

@anandbaburajan anandbaburajan merged commit 0077659 into frappe:develop Sep 6, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
(cherry picked from commit 0077659)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.py
anandbaburajan added a commit that referenced this pull request Sep 6, 2023
* chore: asset finance books validation (#36979)

(cherry picked from commit 0077659)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.py

* chore: fix conflicts

* chore: fix tests

---------

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
anandbaburajan added a commit that referenced this pull request Sep 6, 2023
* chore: asset finance books validation (#36979)

(cherry picked from commit 0077659)

* chore: fix tests

---------

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant