Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with pricing rule since Aug 2023 , not yet solved at version v14.47.1 #36876

Open
thida-bcn opened this issue Aug 30, 2023 · 19 comments
Open

Comments

@thida-bcn
Copy link

          > When a user changes the exchange rate for a currency in a SI, the rate of the items are automatically updated. But the items which have a discount applied get an incorrect rate because the discount isn't applied again after the rate update. This is due to the `apply_price_list` function (which is called from `conversion_rate` when the exchange rate changes) not applying discount once the rate changes, so fixed that.

there was problem with pricing rule, before update version discount apply well
after updating patch screen refresh frequently and discount amount change

Originally posted by @thida-bcn in #36125 (comment)

@anandbaburajan
Copy link
Contributor

@thida-bcn can you please share the steps to reproduce the issue or a screen recording?

@thida-bcn
Copy link
Author

thida-bcn commented Aug 30, 2023

My discount amount is 4000
system changed frequently
https://github.com/frappe/erpnext/assets/62122640/1d90aac7-3b82-4373-8d38-6bf6c2dce163

@anandbaburajan anandbaburajan changed the title > When a user changes the exchange rate for a currency in a SI, the rate of the items are automatically updated. But the items which have a discount applied get an incorrect rate because the discount isn't applied again after the rate update. This is due to the apply_price_list function (which is called from conversion_rate when the exchange rate changes) not applying discount once the rate changes, so fixed that. problem with pricing rule Aug 30, 2023
@anandbaburajan
Copy link
Contributor

@thida-bcn can you share your pricing rule too?

@thida-bcn
Copy link
Author

thida-bcn commented Aug 30, 2023

Item Price
image
Price List
image
Pricing Rule
urukmdco

image
Item with Multi UOM
image

image

@thida-bcn
Copy link
Author

@thida-bcn can you share your pricing rule too?

Item with Mulit UOM
Pricing Rule Discount Amount

@thida-bcn
Copy link
Author

@thida-bcn
Copy link
Author

1 PK = 35 Pack
Discount Amount 4000 for PK
Price of Pack 8643
Pack / PK 35
Price of PK 302505
Discount of PK 4000
Price of PK after Discount 298505
Now, system calculation changed to Discount of PK 4000.01 or 3999.99
due to decimal issues, we can't proceed our operation

@thida-bcn
Copy link
Author

@thida-bcn can you share your pricing rule too?

hello, any progress?

@anandbaburajan
Copy link
Contributor

anandbaburajan commented Sep 6, 2023

@thida-bcn someone will look into this asap. Notes for the dev: according to @thida-bcn, this issue started after #36125 was merged.

Update: doesn't seem like it's related to #36125, but due to some "tax breakup decimal issue". More details in the comments below.

@thida-bcn
Copy link
Author

@thida-bcn someone will look into this asap. Notes for the dev: according to @thida-bcn, this issue started after #36125 was merged.

hello,
we know that you all busy with event
the issue is not solved out in latest patch
we need it urgent
thanks

@thida-bcn
Copy link
Author

@thida-bcn can you please share the steps to reproduce the issue or a screen recording?

hello, may i know progress?
It had been problems since 2 weeks ago

@thida-bcn
Copy link
Author

thida-bcn commented Sep 12, 2023

latest version (problem) 14.39.0
image
version 13 (correct) 13.41.1
image

problem caused by tax breakup decimal issue

@thida-bcn
Copy link
Author

@thida-bcn someone will look into this asap. Notes for the dev: according to @thida-bcn, this issue started after #36125 was merged.

hello sir,
may i know progress?

@anandbaburajan
Copy link
Contributor

@thida-bcn what do you mean by "latest version" in this comment? Is it the latest version of develop or v14 branch? Also you mention that the issue is not there on v13, but #36125 is there on v13 as well, so it doesn't seem like the issue is due to #36125. It could be due to #36235 since you've mentioned tax breakup issues.

Thanks for your patience. Like I said earlier, someone will look into this asap.

@thida-bcn
Copy link
Author

@thida-bcn what do you mean by "latest version" in this comment? Is it the latest version of develop or v14 branch? Also you mention that the issue is not there on v13, but #36125 is there on v13 as well, so it doesn't seem like the issue is due to #36125. It could be due to #36235 since you've mentioned tax breakup issues.

Thanks for your patience. Like I said earlier, someone will look into this asap.

#36876 (comment)

@thida-bcn
Copy link
Author

image

@thida-bcn
Copy link
Author

@thida-bcn what do you mean by "latest version" in this comment? Is it the latest version of develop or v14 branch? Also you mention that the issue is not there on v13, but #36125 is there on v13 as well, so it doesn't seem like the issue is due to #36125. It could be due to #36235 since you've mentioned tax breakup issues.

Thanks for your patience. Like I said earlier, someone will look into this asap.

it was still happening version 14.44.0

@thida-bcn
Copy link
Author

@thida-bcn can you share your pricing rule too?

hi, issue still happening v14.47.1

@thida-bcn thida-bcn changed the title problem with pricing rule problem with pricing rule since Aug 2023 , not yet solved at version v14.47.1 Nov 9, 2023
@thida-bcn
Copy link
Author

@thida-bcn what do you mean by "latest version" in this comment? Is it the latest version of develop or v14 branch? Also you mention that the issue is not there on v13, but #36125 is there on v13 as well, so it doesn't seem like the issue is due to #36125. It could be due to #36235 since you've mentioned tax breakup issues.

Thanks for your patience. Like I said earlier, someone will look into this asap.

hello, may i know progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants