fix: apply discount on item after applying price list #36125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
added
backport develop
anandbaburajan
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
(cherry picked from commit bde9e89) # Conflicts: # erpnext/public/js/controllers/transaction.js # erpnext/selling/sales_common.js
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
(cherry picked from commit bde9e89) # Conflicts: # erpnext/public/js/controllers/transaction.js # erpnext/selling/sales_common.js
This was referenced Jul 25, 2023
anandbaburajan
removed
backport develop
This was referenced Jul 25, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
## [13.52.7](v13.52.6...v13.52.7) (2023-07-26) ### Bug Fixes * allow both custodian and location while creating asset (backport [#36263](#36263)) ([#36270](#36270)) ([e4f28e8](e4f28e8)) * apply discount on item after applying price list ([#36125](#36125)) ([bde9e89](bde9e89)) * group by in fixed asset register (copy [#36310](#36310)) ([#36312](#36312)) ([a5e1c47](a5e1c47))
|
🎉 This PR is included in version 13.52.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
there was problem with pricing rule, before update version discount apply well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user changes the exchange rate for a currency in a SI, the rate of the items are automatically updated. But the items which have a discount applied get an incorrect rate because the discount isn't applied again after the rate update. This is due to the
apply_price_listfunction (which is called fromconversion_ratewhen the exchange rate changes) not applying discount once the rate changes, so fixed that.