feat: add Partly Paid status in Invoices
#27310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruthvi145
force-pushed
the
feat-partially-paid
branch
from
feb7903
to
47bf78a
Compare
|
cool |
sagarvora
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #27310 +/- ##
===========================================
+ Coverage 54.51% 54.54% +0.03%
===========================================
Files 1333 1333
Lines 70731 70737 +6
===========================================
+ Hits 38556 38586 +30
+ Misses 32175 32151 -24
|
|
@pruthvi145 please sort the imports with You can ignore errors that are not from your change... we will take care of them 😅 |
Done! I have sorted for all files(2). |
sagarvora
added
the
squash
barredterra
reviewed
Sep 15, 2021
There was a problem hiding this comment.
Tested, looks good to me. Thanks for your work, @pruthvi145!
I think we should add a unit test for Partly Paid status to make this PR complete.
sagarvora
force-pushed
the
feat-partially-paid
branch
from
e05b016
to
bbfff24
Compare
sagarvora
force-pushed
the
feat-partially-paid
branch
from
9d17a18
to
0e979e3
Compare
barredterra
previously approved these changes
Sep 20, 2021
sagarvora
changed the title
Partly Paid statePartly Paid status in Invoices
| }, | ||
| { | ||
| "fieldname": "scan_barcode", | ||
| "fieldtype": "Data", | ||
| "label": "Scan Barcode", | ||
| "options": "Barcode" | ||
| "label": "Scan Barcode" |
There was a problem hiding this comment.
Suggested change
| "label": "Scan Barcode" | |
| "label": "Scan Barcode", | |
| "options": "Barcode" |
| @@ -15,6 +15,7 @@ frappe.listview_settings['Sales Invoice'] = { | |||
| "Unpaid and Discounted": "orange", | |||
| "Overdue and Discounted": "red", | |||
| "Overdue": "red", | |||
| "Partly Paid": "yellow", | |||
There was a problem hiding this comment.
Suggested change
| "Partly Paid": "yellow", | |
| "Partly Paid": "yellow", | |
| "Partly Paid and Discounted": "yellow", |
nextchamp-saqib
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getdate()instead ofCURDATE()to get accurate dates based on timezones set in System Settings.Behaviour
If a part of the invoice amount has been received,
Partly Paidstate will be shown (instead ofUnpaid). If any scheduled payment (as specified in the Payment Schedule table) is pending beyond it's due date, theOverduestate will be shown.Documentation
https://docs.erpnext.com/docs/v13/user/manual/en/accounts/purchase-invoice/edit?wiki_page_patch=a8b85aba51
https://docs.erpnext.com/docs/v13/user/manual/en/accounts/sales-invoice/edit?wiki_page_patch=709cb5df15