Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Partly Paid status in Invoices #27625

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

sagarvora
Copy link
Collaborator

@sagarvora sagarvora commented Sep 21, 2021

Behaviour

If a part of the invoice amount has been received, Partly Paid state will be shown (instead of Unpaid). If any scheduled payment (as specified in the Payment Schedule table) is pending beyond it's due date, the Overdue state will be shown.

Documentation

https://docs.erpnext.com/docs/v13/user/manual/en/accounts/purchase-invoice/edit?wiki_page_patch=a8b85aba51
https://docs.erpnext.com/docs/v13/user/manual/en/accounts/sales-invoice/edit?wiki_page_patch=709cb5df15

Reopened from #27310

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #27625 (2deb312) into develop (2af6ea6) will increase coverage by 0.07%.
The diff coverage is 88.46%.

❗ Current head 2deb312 differs from pull request most recent head 7841083. Consider uploading reports for the commit 7841083 to get more accurate results

@@             Coverage Diff             @@
##           develop   #27625      +/-   ##
===========================================
+ Coverage    54.50%   54.58%   +0.07%     
===========================================
  Files         1333     1333              
  Lines        70731    70736       +5     
===========================================
+ Hits         38553    38611      +58     
+ Misses       32178    32125      -53     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 83.65% <0.00%> (ø)
...xt/accounts/doctype/sales_invoice/sales_invoice.py 75.42% <94.73%> (+0.21%) ⬆️
...ounts/doctype/purchase_invoice/purchase_invoice.py 81.35% <100.00%> (-0.03%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 78.33% <0.00%> (-2.50%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 45.11% <0.00%> (-1.51%) ⬇️
erpnext/portal/utils.py 30.00% <0.00%> (-1.43%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 92.80% <0.00%> (-0.72%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 67.90% <0.00%> (-0.44%) ⬇️
erpnext/selling/doctype/sales_order/sales_order.py 75.55% <0.00%> (-0.38%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.34% <0.00%> (-0.27%) ⬇️
... and 19 more

@sagarvora
Copy link
Collaborator Author

Known Bug (not due to this PR)

When the cron job to update Overdue status in invoices runs, it sets the status for Sales Invoices that should've had the status Overdue and Discounted to simply Overdue

@sagarvora sagarvora added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Sep 22, 2021
@sagarvora sagarvora merged commit c8b9a55 into frappe:develop Sep 22, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Sep 22, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Sales Invoice as Overdue when first payment becomes overdue
1 participant