-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issues in Bank Reconciliation tool #28996
Merged
deepeshgarg007
merged 2 commits into
frappe:version-13-hotfix
from
deepeshgarg007:bank_reco_tool_fixes
Dec 28, 2021
Merged
fix: Issues in Bank Reconciliation tool #28996
deepeshgarg007
merged 2 commits into
frappe:version-13-hotfix
from
deepeshgarg007:bank_reco_tool_fixes
Dec 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport develop |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Dec 28, 2021
fix: Issues in Bank Reconciliation tool (backport #28996)
fproldan
added a commit
to fproldan/erpnext
that referenced
this pull request
Jan 28, 2022
ValentinaPruvost
pushed a commit
to fproldan/erpnext
that referenced
this pull request
Jan 28, 2022
* trans: action in bank transaction tool * trans: columns names in table * trans: table row * trans: table row * trans: table row * trans: table row * fix: apply frappe#29098 * fix: apply frappe#29366 * fix: apply frappe#28996 * trans: fix
fproldan
added a commit
to fproldan/erpnext
that referenced
this pull request
Jan 28, 2022
ValentinaPruvost
pushed a commit
to fproldan/erpnext
that referenced
this pull request
Jan 31, 2022
* trans: columns names in table * trans: table row * trans: table row * trans: table row * trans: table row * fix: apply frappe#29098 * fix: apply frappe#29366 * fix: apply frappe#28996 * trans: fix * trans: action in bank transaction tool * trans: fix
fproldan
added a commit
to fproldan/erpnext
that referenced
this pull request
Mar 14, 2022
* trans: action in bank transaction tool * trans: columns names in table * trans: table row * trans: table row * trans: table row * trans: table row * fix: apply frappe#29098 * fix: apply frappe#29366 * fix: apply frappe#28996 * trans: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read about bank reco in ERPNext https://docs.erpnext.com/docs/v13/user/manual/en/accounts/bank-reconciliation
The mapping of the bank accounts is maintained at the bank level. But however, one bank could have both types of bank account like Asset (Savings and Current Account) and Liability like (Credit Card Accounts). Now there was an issue while reconciling the bank transactions of the bank account of type liability. The amount to be reconciled was shown as 0 for such transactions and it became difficult to reconcile such a transaction
Steps to test the issue: