Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues in Bank Reconciliation tool #28996

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Dec 22, 2021

Read about bank reco in ERPNext https://docs.erpnext.com/docs/v13/user/manual/en/accounts/bank-reconciliation

The mapping of the bank accounts is maintained at the bank level. But however, one bank could have both types of bank account like Asset (Savings and Current Account) and Liability like (Credit Card Accounts). Now there was an issue while reconciling the bank transactions of the bank account of type liability. The amount to be reconciled was shown as 0 for such transactions and it became difficult to reconcile such a transaction

Steps to test the issue:

  1. Create a bank and add mapping for bank statement import
  2. Make a bank account and map a company account of type liability
  3. Import bank statements for the above-created bank account.
  4. Add a JV for expenses using such a bank account and check

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport develop

@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport develop

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@deepeshgarg007 deepeshgarg007 merged commit 701bca5 into frappe:version-13-hotfix Dec 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 28, 2021

backport develop

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Dec 28, 2021
fix: Issues in Bank Reconciliation tool (backport #28996)
fproldan added a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
* trans: action in bank transaction tool

* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix
fproldan added a commit to fproldan/erpnext that referenced this pull request Jan 28, 2022
ValentinaPruvost pushed a commit to fproldan/erpnext that referenced this pull request Jan 31, 2022
* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix

* trans: action in bank transaction tool

* trans: fix
fproldan added a commit to fproldan/erpnext that referenced this pull request Mar 14, 2022
* trans: action in bank transaction tool

* trans: columns names in table

* trans: table row

* trans: table row

* trans: table row

* trans: table row

* fix: apply frappe#29098

* fix: apply frappe#29366

* fix: apply frappe#28996

* trans: fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant