Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues in Bank Reconciliation tool (backport #28996) #29054

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 28, 2021

This is an automatic backport of pull request #28996 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #29054 (6405699) into develop (27b157d) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff            @@
##           develop   #29054   +/-   ##
========================================
  Coverage    55.61%   55.61%           
========================================
  Files         1128     1128           
  Lines        67345    67343    -2     
========================================
+ Hits         37451    37454    +3     
+ Misses       29894    29889    -5     
Impacted Files Coverage Δ
...nk_reconciliation_tool/bank_reconciliation_tool.py 45.23% <50.00%> (+1.12%) ⬆️
...ounts/doctype/bank_transaction/bank_transaction.py 72.85% <50.00%> (ø)
erpnext/utilities/product.py 14.70% <0.00%> (-35.30%) ⬇️
erpnext/shopping_cart/product_info.py 30.30% <0.00%> (-21.22%) ⬇️
...payroll/doctype/income_tax_slab/income_tax_slab.py 83.33% <0.00%> (-16.67%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 84.93% <0.00%> (-2.74%) ⬇️
...e/shopping_cart_settings/shopping_cart_settings.py 65.38% <0.00%> (-1.93%) ⬇️
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.16% <0.00%> (-1.64%) ⬇️
erpnext/shopping_cart/product_query.py 61.19% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 28.98% <0.00%> (-1.45%) ⬇️
... and 21 more

@deepeshgarg007 deepeshgarg007 merged commit 2248841 into develop Dec 28, 2021
@mergify mergify bot deleted the mergify/bp/develop/pr-28996 branch December 28, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant