Subscription currency #29036
Closed
Subscription currency #29036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedAlNazili
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
| for item in items_list: | ||
| item['cost_center'] = self.cost_center | ||
| invoice.append('items', item) | ||
| # currency | ||
| invoice.currency = temp_currency |
There was a problem hiding this comment.
@MohammedAlNazili this doesn't look like a correct fix to me. One subscription could have multiple subscription plans and by this logic, the invoice will be made in the currency of the last subscription plan in the child table.
The invoice current should be the party account currency and independent of the subscription plan
I have tried to resolve this in the following PR. Please update your site and check if this helps
#28916
For now closing this PR
There was a problem hiding this comment.
I tried to make subscriptions accept subscription plans in one currency in entry and by accepting one currency I can take first or last.
but with Customer currency, I think it is better.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29029 (comment)
Base on issue we have created ...
After creating a subscription plan based on different company default currency and adding a subscription for customer and price base one price list.
when creating invoices it passes the default currency and the balance show not correct
Subscription Plan
Item Price
Sales Invoices
Module
accounts
Version
ERPNext: v13.17.0 (version-13)
Frappe Framework: v13.17.1 (version-13)
Installation method
manual install
Relevant log output / Stack trace / Full Error Message.
No response