fix: handle ImportError
when installing country fixtures
#30055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for moving regional functionality into a separate app.
os.path.exists
succeeds onerpnext/regional/india
even after pulling ERPNext with India-specific code removed. This is becausegit
does not remove empty folders when pulling changes.Solution: Allow
ImportError
to pass silently instead of checking path. This would mean thatinstall_country_fixtures
will work only ifcountry/setup.py
orcountry/setup/__init__.py
file is found.ImportError
is the parent exception ofModuleNotFoundError
, which is what was getting raised previously: