Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs created after remove-india #104

Closed
25 tasks done
DaizyModi opened this issue Jun 16, 2022 · 3 comments
Closed
25 tasks done

PRs created after remove-india #104

DaizyModi opened this issue Jun 16, 2022 · 3 comments
Assignees

Comments

@DaizyModi
Copy link
Contributor

DaizyModi commented Jun 16, 2022

Useful

Need to merge?

Not Required to merge

  1. fix(india): e-invoice eligibility if company gstin is not configured (backport #31247) frappe/erpnext#31275: As we had removed utils.py from erpnext, no need to merge this PR
  2. fix(India): GSTIN filter in GSTR-1 report (backport #31218) frappe/erpnext#31234: As def get_company_gstin() has been refactored in the new India Compliance app with the def get_company_gstin_number() in gstr_1.py
  3. fix(india): duplicate qrcode and hide button (backport #31100) frappe/erpnext#31154: Changes related to QR code in e_invoice utils.
  4. fix(india): minor e-invoicing fixes frappe/erpnext#30553: As we are checking for max_length=18 in def get_mode_of_payment()
  5. fix(india): error while parsing e-invoice (backport #31053) frappe/erpnext#31061: Fix for Json Parse in utils.py
  6. fix: discount ledger entry in case of multicurrency invoice frappe/erpnext#31024: Related to e_invoice/utils.py but not needed
  7. fix(accounts): minor fixes & validations frappe/erpnext#30968:
  8. fix(india): re-arrange e-way bill dialog fields (backport #30920) frappe/erpnext#30941: No need as we have already taken care of fields in proper order
  9. feat(india): E Invoice Cancel Eway Bill is enabled. (backport #30888) frappe/erpnext#30924: No need, already added cancel e-waybill
  10. fix(india): e-invoice generation for registered composition gst category type (backport #30814) frappe/erpnext#30877: Already added B2B for Register Composition and Registered Regular gst category
  11. fix(India): Supply type for overseas invoices with payment of tax (backport #30875) frappe/erpnext#30876: No need as supply_type is already managed as per requirements
  12. fix(india): transporter name is null while generating e-way bill (backport #30736) frappe/erpnext#30747: No need as already using transporter_name as TransName in e-waybill
  13. fix(india): minor e-invoicing fixes (backport #30553) frappe/erpnext#30580: e_invoice print format changes. Added condition for if signed_invoice is available.
@sagarvora
Copy link
Member

sagarvora commented Jun 17, 2022

@DaizyModi
Copy link
Contributor Author

DaizyModi commented Jun 18, 2022

@sagarvora
Copy link
Member

sagarvora commented Jun 18, 2022

Pending (to be done after discussion with Deepesh):

@sagarvora sagarvora changed the title Compliation list for India Compliace PRs created after remove-india Jun 21, 2022
@sagarvora sagarvora changed the title PRs created after remove-india PRs created after remove-india Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants