Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): minimum required changes for postgres builds #30774

Merged
merged 9 commits into from
Apr 26, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 21, 2022

  • Ignore duplicate fixtures in India setup (it's ignored by catching exception anyway)
  • Fix several queries which are blocking creation of test fixtures.

TODO:

  • Fix stock_ledger.py queries (separate PR) All stock ledger-related queries completely block tests from starting.

@ankush ankush added the postgres issue/pr related to postgres label Apr 21, 2022
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Apr 21, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Apr 21, 2022
@ankush ankush force-pushed the postgres/stock branch 3 times, most recently from 290e9c7 to 9748cb8 Compare April 24, 2022 14:57
@ankush ankush changed the title refactor: use db agnostic CombineDatetime fix(postgres): minimum required changes for postgres builds Apr 24, 2022
@ankush ankush force-pushed the postgres/stock branch 2 times, most recently from ed1be22 to 1e90388 Compare April 26, 2022 05:11
@ankush ankush force-pushed the postgres/stock branch 2 times, most recently from c222345 to ef148bc Compare April 26, 2022 06:06
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #30774 (88e257f) into develop (4ffea61) will decrease coverage by 0.11%.
The diff coverage is 96.15%.

@@             Coverage Diff             @@
##           develop   #30774      +/-   ##
===========================================
- Coverage    61.47%   61.35%   -0.12%     
===========================================
  Files         1079     1079              
  Lines        69583    69593      +10     
===========================================
- Hits         42775    42700      -75     
- Misses       26808    26893      +85     
Impacted Files Coverage Δ
erpnext/accounts/party.py 78.09% <ø> (-4.33%) ⬇️
erpnext/manufacturing/doctype/bom/bom.py 87.48% <ø> (ø)
erpnext/stock/doctype/stock_entry/stock_entry.py 81.11% <ø> (ø)
erpnext/stock/doctype/item_price/item_price.py 94.73% <92.85%> (-1.10%) ⬇️
erpnext/accounts/doctype/tax_rule/tax_rule.py 91.20% <100.00%> (+0.29%) ⬆️
erpnext/crm/doctype/opportunity/opportunity.py 69.30% <100.00%> (-0.94%) ⬇️
erpnext/regional/india/setup.py 94.24% <100.00%> (-1.05%) ⬇️
erpnext/stock/stock_ledger.py 88.25% <100.00%> (-0.04%) ⬇️
erpnext/stock/utils.py 77.15% <100.00%> (-0.09%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
... and 31 more

@ankush
Copy link
Member Author

ankush commented Apr 26, 2022

merging this. Postgres tests are gonna fail for a foreseeable future 😄

@ankush ankush merged commit 8d20da9 into frappe:develop Apr 26, 2022
@ankush ankush deleted the postgres/stock branch April 26, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgres issue/pr related to postgres stock
Projects
Development

Successfully merging this pull request may close these issues.

1 participant