-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postgres): minimum required changes for postgres builds #30774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
postgres/stock
branch
3 times, most recently
from
April 24, 2022 14:57
290e9c7
to
9748cb8
Compare
ankush
changed the title
refactor: use db agnostic
fix(postgres): minimum required changes for postgres builds
Apr 24, 2022
CombineDatetime
ankush
force-pushed
the
postgres/stock
branch
2 times, most recently
from
April 26, 2022 05:11
ed1be22
to
1e90388
Compare
ankush
force-pushed
the
postgres/stock
branch
2 times, most recently
from
April 26, 2022 05:34
0defa8c
to
ef148bc
Compare
ankush
requested review from
ruchamahabal,
pateljannat,
marination,
rohitwaghchaure,
nextchamp-saqib and
deepeshgarg007
as code owners
April 26, 2022 05:34
ankush
removed request for
rohitwaghchaure,
ruchamahabal,
nextchamp-saqib and
marination
April 26, 2022 06:04
ankush
force-pushed
the
postgres/stock
branch
2 times, most recently
from
April 26, 2022 06:06
c222345
to
ef148bc
Compare
postgres doesn't like bad type comparisons and doesn't have `isnull` funciton
Codecov Report
@@ Coverage Diff @@
## develop #30774 +/- ##
===========================================
- Coverage 61.47% 61.35% -0.12%
===========================================
Files 1079 1079
Lines 69583 69593 +10
===========================================
- Hits 42775 42700 -75
- Misses 26808 26893 +85
|
merging this. Postgres tests are gonna fail for a foreseeable future 😄 |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: