-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pos): freeze screen while processing pos invoices #30850
Merged
nextchamp-saqib
merged 2 commits into
frappe:develop
from
HarryPaulo:fix-multi-click-button-save
May 27, 2022
Merged
fix(pos): freeze screen while processing pos invoices #30850
nextchamp-saqib
merged 2 commits into
frappe:develop
from
HarryPaulo:fix-multi-click-button-save
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave botton. In situations where the cashier has many POS Invoice 100+, the screen is very slow because the rules were created in javascript, so it happens that the user clicks more than once on the save button because he thinks that nothing is being done. When the user clicks the button several times, the expected value of the closing is totally wrong...
waiting for a return |
nextchamp-saqib
changed the title
fix: freeze the screen to block the user to click multiples time on Save botton.
fix(pos): freeze screen while processing pos invoices
May 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2022
(cherry picked from commit 4b04694)
deepeshgarg007
added a commit
that referenced
this pull request
May 31, 2022
…-30850 fix(pos): freeze screen while processing pos invoices (backport #30850)
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2022
# [13.32.0](v13.31.1...v13.32.0) (2022-05-31) ### Bug Fixes * add list view settings for Gratuity ([e4426ad](e4426ad)) * amount precision for Tax Exemption Proof Submission ([bb04e4b](bb04e4b)) * component pay calculation ([b1e119d](b1e119d)) * conflicts ([cdb884b](cdb884b)) * conflicts ([c02a89d](c02a89d)) * conflicts ([6aa6114](6aa6114)) * date filter on quality inspection report (backport [#31148](#31148)) ([#31164](#31164)) ([f19747c](f19747c)) * Exchange rate reste to 1 on making mapped doc ([91863c7](91863c7)) * Gratuity status not updated on salary slip submission ([0a014ed](0a014ed)) * HRA Exemption calculation in case of multiple salary structure assignments ([de8f5f8](de8f5f8)) * Improve button labels in Warehouse (backport [#31101](#31101)) ([#31150](#31150)) ([d891394](d891394)) * **india:** duplicate qrcode and hide button ([#31154](#31154)) ([f40100d](f40100d)) * Job Opening linked to Staffing Plan cannot be created/updated if there are existing employees ([b4a3a53](b4a3a53)) * **pos:** freeze screen while processing pos invoices ([#30850](#30850)) ([a7bf236](a7bf236)) * skip existing batch number during autogen (backport [#31140](#31140)) ([#31144](#31144)) ([a380bae](a380bae)) * Tax Declaration tests and amount precision ([1e728df](1e728df)) * validation message ([096ae21](096ae21)) ### Features * Auto accrue loan interest for backdated term loans ([89c4d51](89c4d51)) * live preview of naming series on naming series tool (backport [#31141](#31141)) ([#31146](#31146)) ([fd2f3b9](fd2f3b9)) * provision to exclude exploded items in the BOM (backport [#29450](#29450)) ([#31174](#31174)) ([50d338d](50d338d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the cashier has many POS Invoice 100+, the screen is very slow because the rules were created in javascript, so it happens that the user clicks more than once on the save button because he thinks that nothing is being done.
When the user clicks the button several times, the expected value of the closing is totally wrong...