-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: live preview of naming series on naming series tool #31141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #31141 +/- ##
===========================================
+ Coverage 63.10% 63.13% +0.02%
===========================================
Files 986 986
Lines 67391 67417 +26
===========================================
+ Hits 42527 42562 +35
+ Misses 24864 24855 -9
|
separate commit to avoid mixing actual changes
ankush
force-pushed
the
naming_series_live_preview
branch
from
May 26, 2022 09:51
d682c76
to
24d1bf5
Compare
ankush
added a commit
that referenced
this pull request
May 26, 2022
…31141) (#31146) * chore: resave naming series doctype schema separate commit to avoid mixing actual changes (cherry picked from commit 82cd54b) * feat: preview next numbers on naming series tool (cherry picked from commit 24d1bf5) * docs: update help information on naming series (cherry picked from commit 4d0e2aa) * test: add basic tests for naming series tool (cherry picked from commit 964b418) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2022
# [13.32.0](v13.31.1...v13.32.0) (2022-05-31) ### Bug Fixes * add list view settings for Gratuity ([e4426ad](e4426ad)) * amount precision for Tax Exemption Proof Submission ([bb04e4b](bb04e4b)) * component pay calculation ([b1e119d](b1e119d)) * conflicts ([cdb884b](cdb884b)) * conflicts ([c02a89d](c02a89d)) * conflicts ([6aa6114](6aa6114)) * date filter on quality inspection report (backport [#31148](#31148)) ([#31164](#31164)) ([f19747c](f19747c)) * Exchange rate reste to 1 on making mapped doc ([91863c7](91863c7)) * Gratuity status not updated on salary slip submission ([0a014ed](0a014ed)) * HRA Exemption calculation in case of multiple salary structure assignments ([de8f5f8](de8f5f8)) * Improve button labels in Warehouse (backport [#31101](#31101)) ([#31150](#31150)) ([d891394](d891394)) * **india:** duplicate qrcode and hide button ([#31154](#31154)) ([f40100d](f40100d)) * Job Opening linked to Staffing Plan cannot be created/updated if there are existing employees ([b4a3a53](b4a3a53)) * **pos:** freeze screen while processing pos invoices ([#30850](#30850)) ([a7bf236](a7bf236)) * skip existing batch number during autogen (backport [#31140](#31140)) ([#31144](#31144)) ([a380bae](a380bae)) * Tax Declaration tests and amount precision ([1e728df](1e728df)) * validation message ([096ae21](096ae21)) ### Features * Auto accrue loan interest for backdated term loans ([89c4d51](89c4d51)) * live preview of naming series on naming series tool (backport [#31141](#31141)) ([#31146](#31146)) ([fd2f3b9](fd2f3b9)) * provision to exclude exploded items in the BOM (backport [#29450](#29450)) ([#31174](#31174)) ([50d338d](50d338d))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming series are a frequent source of confusion and often require multiple attempts to get right.
This PR adds a new field on the naming series tool to try out different naming series(what is the plural? seriesen? seri?).
Screen.Recording.2022-05-26.at.3.06.46.PM.mov
Updated help info on page:
docs: https://docs.erpnext.com/docs/v14/user/manual/en/setting-up/settings/naming-series#6-live-preview (in-app help are also enough for this)
closes #30519