Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: live preview of naming series on naming series tool #31141

Merged
merged 4 commits into from
May 26, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented May 26, 2022

Naming series are a frequent source of confusion and often require multiple attempts to get right.

This PR adds a new field on the naming series tool to try out different naming series(what is the plural? seriesen? seri?).

Screen.Recording.2022-05-26.at.3.06.46.PM.mov

Updated help info on page:

Screenshot 2022-05-26 at 3 38 07 PM

docs: https://docs.erpnext.com/docs/v14/user/manual/en/setting-up/settings/naming-series#6-live-preview (in-app help are also enough for this)

closes #30519

@ankush ankush marked this pull request as draft May 26, 2022 07:52
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #31141 (964b418) into develop (5c74514) will increase coverage by 0.02%.
The diff coverage is 68.18%.

@@             Coverage Diff             @@
##           develop   #31141      +/-   ##
===========================================
+ Coverage    63.10%   63.13%   +0.02%     
===========================================
  Files          986      986              
  Lines        67391    67417      +26     
===========================================
+ Hits         42527    42562      +35     
+ Misses       24864    24855       -9     
Impacted Files Coverage Δ
...pnext/setup/doctype/naming_series/naming_series.py 53.28% <68.18%> (+15.88%) ⬆️
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-37.51%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-16.84%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
erpnext/hr/doctype/job_offer/job_offer.py 82.92% <0.00%> (-4.88%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
erpnext/hr/doctype/job_applicant/job_applicant.py 63.93% <0.00%> (-3.28%) ⬇️
...value/warehouse_wise_item_balance_age_and_value.py 89.02% <0.00%> (-2.44%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 93.75% <0.00%> (-1.45%) ⬇️
... and 24 more

@ankush ankush force-pushed the naming_series_live_preview branch from d682c76 to 24d1bf5 Compare May 26, 2022 09:51
@ankush ankush marked this pull request as ready for review May 26, 2022 09:51
@ankush ankush merged commit ff798dc into frappe:develop May 26, 2022
@ankush ankush deleted the naming_series_live_preview branch May 26, 2022 11:20
ankush added a commit that referenced this pull request May 26, 2022
…31141) (#31146)

* chore: resave naming series doctype schema

separate commit to avoid mixing actual changes

(cherry picked from commit 82cd54b)

* feat: preview next numbers on naming series tool

(cherry picked from commit 24d1bf5)

* docs: update help information on naming series

(cherry picked from commit 4d0e2aa)

* test: add basic tests for naming series tool

(cherry picked from commit 964b418)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request May 31, 2022
# [13.32.0](v13.31.1...v13.32.0) (2022-05-31)

### Bug Fixes

* add list view settings for Gratuity ([e4426ad](e4426ad))
* amount precision for Tax Exemption Proof Submission ([bb04e4b](bb04e4b))
* component pay calculation ([b1e119d](b1e119d))
* conflicts ([cdb884b](cdb884b))
* conflicts ([c02a89d](c02a89d))
* conflicts ([6aa6114](6aa6114))
* date filter on quality inspection report (backport [#31148](#31148)) ([#31164](#31164)) ([f19747c](f19747c))
* Exchange rate reste to 1 on making mapped doc ([91863c7](91863c7))
* Gratuity status not updated on salary slip submission ([0a014ed](0a014ed))
* HRA Exemption calculation in case of multiple salary structure assignments ([de8f5f8](de8f5f8))
* Improve button labels in Warehouse (backport [#31101](#31101)) ([#31150](#31150)) ([d891394](d891394))
* **india:** duplicate qrcode and hide button ([#31154](#31154)) ([f40100d](f40100d))
* Job Opening linked to Staffing Plan cannot be created/updated if there are existing employees ([b4a3a53](b4a3a53))
* **pos:** freeze screen while processing pos invoices ([#30850](#30850)) ([a7bf236](a7bf236))
* skip existing batch number during autogen (backport [#31140](#31140)) ([#31144](#31144)) ([a380bae](a380bae))
* Tax Declaration tests and amount precision ([1e728df](1e728df))
* validation message ([096ae21](096ae21))

### Features

* Auto accrue loan interest for backdated term loans ([89c4d51](89c4d51))
* live preview of naming series on naming series tool (backport [#31141](#31141)) ([#31146](#31146)) ([fd2f3b9](fd2f3b9))
* provision to exclude exploded items in the BOM (backport [#29450](#29450)) ([#31174](#31174)) ([50d338d](50d338d))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

Live preview of naming series
1 participant