fix(india): invoice type for a debit note e-invoice #30948

nextchamp-saqib · 2022-05-10T06:52:00Z

When creating a Debit Note, the e-invoice should be of type DBN

codecov · 2022-05-10T07:15:14Z

Codecov Report

Merging #30948 (fbc6201) into develop (c05144f) will decrease coverage by 0.00%.
The diff coverage is 26.66%.

@@             Coverage Diff             @@
##           develop   #30948      +/-   ##
===========================================
- Coverage    63.01%   63.00%   -0.01%     
===========================================
  Files          983      983              
  Lines        67062    67102      +40     
===========================================
+ Hits         42256    42276      +20     
- Misses       24806    24826      +20

Impacted Files	Coverage Δ
erpnext/regional/india/e_invoice/utils.py	`40.42% <26.66%> (-1.60%)`	⬇️
...saction/incorrect_balance_qty_after_transaction.py	`88.37% <0.00%> (-9.31%)`	⬇️
...t/accounts/report/sales_register/sales_register.py	`70.76% <0.00%> (-7.02%)`	⬇️
...urity_shortfall/process_loan_security_shortfall.py	`93.75% <0.00%> (-6.25%)`	⬇️
erpnext/hr/utils.py	`73.10% <0.00%> (-4.63%)`	⬇️
erpnext/accounts/party.py	`78.09% <0.00%> (-4.33%)`	⬇️
...em_wise_sales_register/item_wise_sales_register.py	`61.08% <0.00%> (-2.27%)`	⬇️
.../report/bom_operations_time/bom_operations_time.py	`89.13% <0.00%> (-2.18%)`	⬇️
erpnext/portal/utils.py	`27.69% <0.00%> (-1.54%)`	⬇️
erpnext/crm/doctype/prospect/prospect.py	`56.71% <0.00%> (-1.50%)`	⬇️
... and 23 more

(cherry picked from commit 8dd046c)

…-30948 fix(india): invoice type for a debit note e-invoice (backport #30948)

# [13.29.0](v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * Consider paryt and party type as well in group by consolidated view ([189fc89](189fc89)) * disable form save on naming series tool ([#30909](#30909)) ([#30910](#30910)) ([d60a6cb](d60a6cb)) * double future qty updates ([0db3013](0db3013)) * HSN-wise-summary of outward supplies Updated Report ([3637525](3637525)) * Ignore loan repayments made from salary slip ([b7e1d40](b7e1d40)) * **india:** invoice type for a debit note e-invoice ([#30948](#30948)) ([c46add3](c46add3)) * **india:** keyerror while generating e-way bill from an e-invoice ([#30879](#30879)) ([98d799e](98d799e)) * **india:** re-arrange e-way bill dialog fields ([#30941](#30941)) ([7ce5c93](7ce5c93)) * Item Alternative Test ([964de1f](964de1f)) * patch for renaming membership settings ([#30929](#30929)) ([9189653](9189653)) * **pos:** creating pos returns resets pricing rules & discounts ([#30936](#30936)) ([a0e39db](a0e39db)) * remove check for already allocated earned leaves ([#30931](#30931)) ([#30932](#30932)) ([80f7d66](80f7d66)) * Remove commit from stock entry test. The assertion is not important ([c449b35](c449b35)) * Set available-for-use date if missing ([#30838](#30838)) ([bf2eaec](bf2eaec)) * show group warehouse in Sales Order ([#30891](#30891)) ([#30893](#30893)) ([c458e14](c458e14)) * Show linked time sheets in sales invoice dashboard ([4f4af52](4f4af52)) * sort before picking next stock reco ([e27fb58](e27fb58)) * subtract change_amount from paid_amount field on POS Register ([#30937](#30937)) ([b7e873b](b7e873b)) * Unlink and delete batch created from stock reco on cancel ([fc35323](fc35323)) * Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](d53228b)) ### Features * **HR:** Leave Type configuration to allow over allocation (backport [#30940](#30940)) ([#30944](#30944)) ([64440fc](64440fc)) * **india:** cancel e-way bill is enabled with e-invoicing APIs. ([#30924](#30924)) ([4ef2ffd](4ef2ffd)) * **india:** generate qrcode button for e-invoice ([#30946](#30946)) ([7bd5b2b](7bd5b2b)) * **india:** store e-way bill auto calculated distance in sales invoice ([#30923](#30923)) ([b96f156](b96f156))

# [13.29.0](frappe/erpnext@v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * Consider paryt and party type as well in group by consolidated view ([189fc89](frappe@189fc89)) * disable form save on naming series tool ([frappe#30909](frappe#30909)) ([frappe#30910](frappe#30910)) ([d60a6cb](frappe@d60a6cb)) * double future qty updates ([0db3013](frappe@0db3013)) * HSN-wise-summary of outward supplies Updated Report ([3637525](frappe@3637525)) * Ignore loan repayments made from salary slip ([b7e1d40](frappe@b7e1d40)) * **india:** invoice type for a debit note e-invoice ([frappe#30948](frappe#30948)) ([c46add3](frappe@c46add3)) * **india:** keyerror while generating e-way bill from an e-invoice ([frappe#30879](frappe#30879)) ([98d799e](frappe@98d799e)) * **india:** re-arrange e-way bill dialog fields ([frappe#30941](frappe#30941)) ([7ce5c93](frappe@7ce5c93)) * Item Alternative Test ([964de1f](frappe@964de1f)) * patch for renaming membership settings ([frappe#30929](frappe#30929)) ([9189653](frappe@9189653)) * **pos:** creating pos returns resets pricing rules & discounts ([frappe#30936](frappe#30936)) ([a0e39db](frappe@a0e39db)) * remove check for already allocated earned leaves ([frappe#30931](frappe#30931)) ([frappe#30932](frappe#30932)) ([80f7d66](frappe@80f7d66)) * Remove commit from stock entry test. The assertion is not important ([c449b35](frappe@c449b35)) * Set available-for-use date if missing ([frappe#30838](frappe#30838)) ([bf2eaec](frappe@bf2eaec)) * show group warehouse in Sales Order ([frappe#30891](frappe#30891)) ([frappe#30893](frappe#30893)) ([c458e14](frappe@c458e14)) * Show linked time sheets in sales invoice dashboard ([4f4af52](frappe@4f4af52)) * sort before picking next stock reco ([e27fb58](frappe@e27fb58)) * subtract change_amount from paid_amount field on POS Register ([frappe#30937](frappe#30937)) ([b7e873b](frappe@b7e873b)) * Unlink and delete batch created from stock reco on cancel ([fc35323](frappe@fc35323)) * Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](frappe@d53228b)) ### Features * **HR:** Leave Type configuration to allow over allocation (backport [frappe#30940](frappe#30940)) ([frappe#30944](frappe#30944)) ([64440fc](frappe@64440fc)) * **india:** cancel e-way bill is enabled with e-invoicing APIs. ([frappe#30924](frappe#30924)) ([4ef2ffd](frappe@4ef2ffd)) * **india:** generate qrcode button for e-invoice ([frappe#30946](frappe#30946)) ([7bd5b2b](frappe@7bd5b2b)) * **india:** store e-way bill auto calculated distance in sales invoice ([frappe#30923](frappe#30923)) ([b96f156](frappe@b96f156))

# [13.29.0](v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * Consider paryt and party type as well in group by consolidated view ([189fc89](189fc89)) * disable form save on naming series tool ([#30909](#30909)) ([#30910](#30910)) ([d60a6cb](d60a6cb)) * double future qty updates ([0db3013](0db3013)) * HSN-wise-summary of outward supplies Updated Report ([3637525](3637525)) * Ignore loan repayments made from salary slip ([b7e1d40](b7e1d40)) * **india:** invoice type for a debit note e-invoice ([#30948](#30948)) ([c46add3](c46add3)) * **india:** keyerror while generating e-way bill from an e-invoice ([#30879](#30879)) ([98d799e](98d799e)) * **india:** re-arrange e-way bill dialog fields ([#30941](#30941)) ([7ce5c93](7ce5c93)) * Item Alternative Test ([964de1f](964de1f)) * patch for renaming membership settings ([#30929](#30929)) ([9189653](9189653)) * **pos:** creating pos returns resets pricing rules & discounts ([#30936](#30936)) ([a0e39db](a0e39db)) * remove check for already allocated earned leaves ([#30931](#30931)) ([#30932](#30932)) ([80f7d66](80f7d66)) * Remove commit from stock entry test. The assertion is not important ([c449b35](c449b35)) * Set available-for-use date if missing ([#30838](#30838)) ([bf2eaec](bf2eaec)) * show group warehouse in Sales Order ([#30891](#30891)) ([#30893](#30893)) ([c458e14](c458e14)) * Show linked time sheets in sales invoice dashboard ([4f4af52](4f4af52)) * sort before picking next stock reco ([e27fb58](e27fb58)) * subtract change_amount from paid_amount field on POS Register ([#30937](#30937)) ([b7e873b](b7e873b)) * Unlink and delete batch created from stock reco on cancel ([fc35323](fc35323)) * Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](d53228b)) ### Features * **HR:** Leave Type configuration to allow over allocation (backport [#30940](#30940)) ([#30944](#30944)) ([64440fc](64440fc)) * **india:** cancel e-way bill is enabled with e-invoicing APIs. ([#30924](#30924)) ([4ef2ffd](4ef2ffd)) * **india:** generate qrcode button for e-invoice ([#30946](#30946)) ([7bd5b2b](7bd5b2b)) * **india:** store e-way bill auto calculated distance in sales invoice ([#30923](#30923)) ([b96f156](b96f156)) (cherry picked from commit 7369db5) # Conflicts: # erpnext/__init__.py

# [13.29.0](frappe/erpnext@v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * Consider paryt and party type as well in group by consolidated view ([189fc89](frappe@189fc89)) * disable form save on naming series tool ([frappe#30909](frappe#30909)) ([frappe#30910](frappe#30910)) ([d60a6cb](frappe@d60a6cb)) * double future qty updates ([0db3013](frappe@0db3013)) * HSN-wise-summary of outward supplies Updated Report ([3637525](frappe@3637525)) * Ignore loan repayments made from salary slip ([b7e1d40](frappe@b7e1d40)) * **india:** invoice type for a debit note e-invoice ([frappe#30948](frappe#30948)) ([c46add3](frappe@c46add3)) * **india:** keyerror while generating e-way bill from an e-invoice ([frappe#30879](frappe#30879)) ([98d799e](frappe@98d799e)) * **india:** re-arrange e-way bill dialog fields ([frappe#30941](frappe#30941)) ([7ce5c93](frappe@7ce5c93)) * Item Alternative Test ([964de1f](frappe@964de1f)) * patch for renaming membership settings ([frappe#30929](frappe#30929)) ([9189653](frappe@9189653)) * **pos:** creating pos returns resets pricing rules & discounts ([frappe#30936](frappe#30936)) ([a0e39db](frappe@a0e39db)) * remove check for already allocated earned leaves ([frappe#30931](frappe#30931)) ([frappe#30932](frappe#30932)) ([80f7d66](frappe@80f7d66)) * Remove commit from stock entry test. The assertion is not important ([c449b35](frappe@c449b35)) * Set available-for-use date if missing ([frappe#30838](frappe#30838)) ([bf2eaec](frappe@bf2eaec)) * show group warehouse in Sales Order ([frappe#30891](frappe#30891)) ([frappe#30893](frappe#30893)) ([c458e14](frappe@c458e14)) * Show linked time sheets in sales invoice dashboard ([4f4af52](frappe@4f4af52)) * sort before picking next stock reco ([e27fb58](frappe@e27fb58)) * subtract change_amount from paid_amount field on POS Register ([frappe#30937](frappe#30937)) ([b7e873b](frappe@b7e873b)) * Unlink and delete batch created from stock reco on cancel ([fc35323](frappe@fc35323)) * Wrap SLE actual_qty in `flt` to avoid NoneType operation ([d53228b](frappe@d53228b)) ### Features * **HR:** Leave Type configuration to allow over allocation (backport [frappe#30940](frappe#30940)) ([frappe#30944](frappe#30944)) ([64440fc](frappe@64440fc)) * **india:** cancel e-way bill is enabled with e-invoicing APIs. ([frappe#30924](frappe#30924)) ([4ef2ffd](frappe@4ef2ffd)) * **india:** generate qrcode button for e-invoice ([frappe#30946](frappe#30946)) ([7bd5b2b](frappe@7bd5b2b)) * **india:** store e-way bill auto calculated distance in sales invoice ([frappe#30923](frappe#30923)) ([b96f156](frappe@b96f156)) (cherry picked from commit 7369db5) # Conflicts: # erpnext/__init__.py

fix(india): invoice type for a debit note e-invoice

fbc6201

nextchamp-saqib requested a review from deepeshgarg007 as a code owner May 10, 2022 06:52

github-actions bot added the needs-tests This PR needs automated unit-tests. label May 10, 2022

nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label May 10, 2022

nextchamp-saqib added the backport version-13-hotfix label May 10, 2022

nextchamp-saqib merged commit 8dd046c into frappe:develop May 10, 2022

mergify bot pushed a commit that referenced this pull request May 10, 2022

fix(india): invoice type for a debit note e-invoice (#30948)

c46add3

(cherry picked from commit 8dd046c)

mergify bot mentioned this pull request May 10, 2022

fix(india): invoice type for a debit note e-invoice (backport #30948) #30949

Merged

deepeshgarg007 added a commit that referenced this pull request May 10, 2022

Merge pull request #30949 from frappe/mergify/bp/version-13-hotfix/pr…

3373ce5

…-30948 fix(india): invoice type for a debit note e-invoice (backport #30948)

hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 10, 2022

fix(india): invoice type for a debit note e-invoice (frappe#30948)

93aa474

This was referenced Jun 17, 2022

PRs created after remove-india resilient-tech/india-compliance#104

Closed

fix: set invoice type for debit note in einvoice resilient-tech/india-compliance#109

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(india): invoice type for a debit note e-invoice #30948

fix(india): invoice type for a debit note e-invoice #30948

nextchamp-saqib commented May 10, 2022

codecov bot commented May 10, 2022

fix(india): invoice type for a debit note e-invoice #30948

fix(india): invoice type for a debit note e-invoice #30948

Conversation

nextchamp-saqib commented May 10, 2022

codecov bot commented May 10, 2022

Codecov Report