-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: internal transfer GLE validation #31264
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
ankush:internal_trasfer_precision_loss
Jun 21, 2022
Merged
fix: internal transfer GLE validation #31264
deepeshgarg007
merged 2 commits into
frappe:develop
from
ankush:internal_trasfer_precision_loss
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
internal_trasfer_precision_loss
branch
2 times, most recently
from
June 7, 2022 09:36
804edf2
to
5c0c08a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #31264 +/- ##
===========================================
- Coverage 63.75% 63.50% -0.25%
===========================================
Files 984 986 +2
Lines 67724 67456 -268
===========================================
- Hits 43179 42841 -338
- Misses 24545 24615 +70
|
ankush
force-pushed
the
internal_trasfer_precision_loss
branch
from
June 7, 2022 10:04
5c0c08a
to
dd58e3a
Compare
ankush
changed the title
fix: precision loss when internal transfer using DN
fix: internal transfer GLE validation
Jun 7, 2022
ankush
force-pushed
the
internal_trasfer_precision_loss
branch
from
June 8, 2022 13:55
dd58e3a
to
8b94a86
Compare
ankush
requested review from
deepeshgarg007,
nextchamp-saqib,
rohitwaghchaure and
marination
as code owners
June 8, 2022 13:55
ankush
force-pushed
the
internal_trasfer_precision_loss
branch
from
June 8, 2022 13:56
8b94a86
to
65b21ee
Compare
25 tasks
deepeshgarg007
approved these changes
Jun 21, 2022
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jun 21, 2022
…-31264 fix: internal transfer GLE validation (backport #31264)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing internal transfers if both accounts are the same a GLE is made with equal credit/debit, this fails validation while submitting the doc.
Soln: toggle credit to negative debit (like done in other transactions)
ps: check added test case for example