Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal transfer GLE validation #31264

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jun 7, 2022

While doing internal transfers if both accounts are the same a GLE is made with equal credit/debit, this fails validation while submitting the doc.

Soln: toggle credit to negative debit (like done in other transactions)

ps: check added test case for example

@github-actions github-actions bot added the stock label Jun 7, 2022
@ankush ankush force-pushed the internal_trasfer_precision_loss branch 2 times, most recently from 804edf2 to 5c0c08a Compare June 7, 2022 09:36
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #31264 (dd58e3a) into develop (46e6c2c) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head dd58e3a differs from pull request most recent head f572c20. Consider uploading reports for the commit f572c20 to get more accurate results

@@             Coverage Diff             @@
##           develop   #31264      +/-   ##
===========================================
- Coverage    63.75%   63.50%   -0.25%     
===========================================
  Files          984      986       +2     
  Lines        67724    67456     -268     
===========================================
- Hits         43179    42841     -338     
- Misses       24545    24615      +70     
Impacted Files Coverage Δ
erpnext/controllers/stock_controller.py 91.64% <ø> (ø)
...ctype/cash_flow_mapper/default_cash_flow_mapper.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/setup/default_energy_point_rules.py 0.00% <0.00%> (-75.00%) ⬇️
erpnext/setup/default_success_action.py 0.00% <0.00%> (-62.50%) ⬇️
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (-28.13%) ⬇️
erpnext/regional/italy/setup.py 0.00% <0.00%> (-27.28%) ⬇️
erpnext/utilities/doctype/video/video.py 0.00% <0.00%> (-21.35%) ⬇️
erpnext/setup/install.py 0.00% <0.00%> (-20.77%) ⬇️
..._arabia/wizard/operations/setup_ksa_vat_setting.py 0.00% <0.00%> (-19.05%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
... and 76 more

@ankush ankush force-pushed the internal_trasfer_precision_loss branch from 5c0c08a to dd58e3a Compare June 7, 2022 10:04
@ankush ankush changed the title fix: precision loss when internal transfer using DN fix: internal transfer GLE validation Jun 7, 2022
@ankush ankush force-pushed the internal_trasfer_precision_loss branch from dd58e3a to 8b94a86 Compare June 8, 2022 13:55
@ankush ankush marked this pull request as ready for review June 8, 2022 13:55
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jun 21, 2022
…-31264

fix: internal transfer GLE validation (backport #31264)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants