-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix a potential variable misuse bug #31372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostBenjamin
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
June 15, 2022 12:36
marination
reviewed
Jun 16, 2022
marination
changed the title
Fix a potential variable misuse bug
chore: Fix a potential variable misuse bug
Jun 16, 2022
marination
previously approved these changes
Jun 16, 2022
marination
added
the
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
label
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## develop #31372 +/- ##
===========================================
+ Coverage 63.61% 63.67% +0.06%
===========================================
Files 984 984
Lines 67556 67559 +3
===========================================
+ Hits 42975 43018 +43
+ Misses 24581 24541 -40
|
marination
approved these changes
Jun 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Fix a potential variable misuse bug * chore: Separate check (separate line) for empty table in Pricing Rule * chore: Code readability & check for field in row (now row itself) Co-authored-by: marination <maricadsouza221197@gmail.com> (cherry picked from commit b4a93da) # Conflicts: # erpnext/accounts/doctype/pricing_rule/pricing_rule.py
marination
added a commit
that referenced
this pull request
Jun 16, 2022
…-31372 chore: Fix a potential variable misuse bug (backport #31372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport version-13-hotfix
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request is a fix to a potential variable misuse bug at
erpnext/accounts/doctype/pricing_rule/pricing_rule.py
. Please check the changes.It seems to me that the variable in the if condition should be
d
to check ifd
isNone
. If the variable should indeed befield
, it would be better to put the condition in a separate if statement.Best,
Jingxuan