perf: GLE reposting with progress and chunking (backport #31343) #31373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
marination,
rohitwaghchaure,
nextchamp-saqib and
deepeshgarg007
as code owners
ankush
force-pushed
the
gle_repost_progress
branch
from
ccc8c86
to
a03f0cc
Compare
ankush
force-pushed
the
gle_repost_progress
branch
3 times, most recently
from
9d2acaf
to
1d709fa
Compare
If stock voucher count goes >1000 then fetching all gles and reposting them all at once requires much more memory and can cause crash. - This PR ensures that GLE reposting is done in chunks of 100 vouchers. - This PR also starts keeping track of how many such chunks were processed so in future progress is resumed in event of timeout.
ankush
force-pushed
the
gle_repost_progress
branch
from
1d709fa
to
fd2ca7b
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
## [13.34.1](v13.34.0...v13.34.1) (2022-06-21) ### Bug Fixes * Conversion rate validation for multi-currency invoices ([4186aaf](4186aaf)) * **india:** e-invoice eligibility if company gstin is not configured ([#31247](#31247)) ([7696ae4](7696ae4)) * internal transfer GLE validation ([8a4cd2a](8a4cd2a)) * Merge Conflicts ([0f3a02d](0f3a02d)) * Pick Template BOM if variant BOM absent in WO popup from SO ([7c35887](7c35887)) * Quotation lost update ([3b9f943](3b9f943)) * Spelling mistake in quotation depend on (backport [#31362](#31362)) ([#31363](#31363)) ([ebcdaf7](ebcdaf7)) * transaction date gets unset in material request ([#31387](#31387)) ([4e2ed6f](4e2ed6f)), closes [#31327](#31327) * UOM handling for transaction without item (backport [#31389](#31389)) ([#31391](#31391)) ([051e5cd](051e5cd)) ### Performance Improvements * GLE reposting with progress and chunking (backport [#31343](#31343)) ([#31373](#31373)) ([f19ed0b](f19ed0b))
|
🎉 This PR is included in version 13.34.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #31343 & #31374