fix: UOM handling for transaction without item #31389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
deepeshgarg007,
nextchamp-saqib,
rohitwaghchaure and
marination
as code owners
If invoice is made without item code then UOM, Stock UOM and conversion_factor all need to be manually added, this is confusing and leads missing them out leads to errors. Simplest solution: - if either UOM exists then set both to same uom conversion factor to - also set conversion factor based on UOM conversions
Codecov Report
@@ Coverage Diff @@
## develop #31389 +/- ##
===========================================
+ Coverage 63.06% 63.56% +0.49%
===========================================
Files 984 984
Lines 67556 67562 +6
===========================================
+ Hits 42604 42944 +340
+ Misses 24952 24618 -334
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
If invoice is made without item code then UOM, Stock UOM and conversion_factor all need to be manually added, this is confusing and leads missing them out leads to errors. Simplest solution: - if either UOM exists then set both to same uom conversion factor to - also set conversion factor based on UOM conversions (cherry picked from commit 10583eb)
ankush
added a commit
that referenced
this pull request
Jun 17, 2022
) fix: UOM handling for transaction without item (#31389) If invoice is made without item code then UOM, Stock UOM and conversion_factor all need to be manually added, this is confusing and leads missing them out leads to errors. Simplest solution: - if either UOM exists then set both to same uom conversion factor to - also set conversion factor based on UOM conversions (cherry picked from commit 10583eb) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
## [13.34.1](v13.34.0...v13.34.1) (2022-06-21) ### Bug Fixes * Conversion rate validation for multi-currency invoices ([4186aaf](4186aaf)) * **india:** e-invoice eligibility if company gstin is not configured ([#31247](#31247)) ([7696ae4](7696ae4)) * internal transfer GLE validation ([8a4cd2a](8a4cd2a)) * Merge Conflicts ([0f3a02d](0f3a02d)) * Pick Template BOM if variant BOM absent in WO popup from SO ([7c35887](7c35887)) * Quotation lost update ([3b9f943](3b9f943)) * Spelling mistake in quotation depend on (backport [#31362](#31362)) ([#31363](#31363)) ([ebcdaf7](ebcdaf7)) * transaction date gets unset in material request ([#31387](#31387)) ([4e2ed6f](4e2ed6f)), closes [#31327](#31327) * UOM handling for transaction without item (backport [#31389](#31389)) ([#31391](#31391)) ([051e5cd](051e5cd)) ### Performance Improvements * GLE reposting with progress and chunking (backport [#31343](#31343)) ([#31373](#31373)) ([f19ed0b](f19ed0b))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If invoice is made without item code then UOM, Stock UOM and
conversion_factor all need to be manually added, this is confusing and
leads missing them out leads to errors.
Simplest solution: