refactor: refactor set_missing_values and set_missing_ref_details in Payment Entry #34922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_missing_ref_details can update only for selected references
github-actions
bot
added
accounts
needs-tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34922 +/- ##
========================================
Coverage 63.86% 63.87%
========================================
Files 810 810
Lines 59712 59750 +38
========================================
+ Hits 38137 38166 +29
- Misses 21575 21584 +9
|
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Apr 21, 2023
…-34922 refactor: refactor set_missing_values and set_missing_ref_details in Payment Entry (backport #34922)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull
set_missing_ref_detailsout ofset_missing_valuesmethod in Payment Entry. This was needed to pick and choose when to update ref details while reconciling large no of invoices.related: #34596, frappe/hrms#458
no-docs