Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update ref details on selected references on Payment Entry #458

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Apr 19, 2023

This was needed to pick and choose when to update ref details while reconciling large no of invoices.

related: frappe/erpnext#34596, frappe/erpnext#34922

@ruthra-kumar ruthra-kumar marked this pull request as ready for review April 19, 2023 11:09
@codecov-commenter
Copy link

Codecov Report

Merging #458 (e341a34) into develop (4580bb1) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #458      +/-   ##
===========================================
- Coverage    72.88%   72.87%   -0.01%     
===========================================
  Files          190      190              
  Lines         9790     9792       +2     
===========================================
+ Hits          7135     7136       +1     
- Misses        2655     2656       +1     
Impacted Files Coverage Δ
hrms/overrides/employee_payment_entry.py 73.20% <66.66%> (-0.31%) ⬇️

@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2023

backport version-14-hotfix

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants