Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accounts closing balance patch #36113

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: Accounts closing balance patch #36113

merged 1 commit into from
Jul 13, 2023

Conversation

deepeshgarg007
Copy link
Member 

  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/account_closing_balance/account_closing_balance.py", line 19, in make_closing_entries
    company = closing_entries[0].get("company")
      closing_entries = []
      voucher_name = 'ACC-PCV-2022-00002'
      accounting_dimensions = []
builtins.IndexError: list index out of range

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 13, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Jul 13, 2023
@deepeshgarg007 deepeshgarg007 merged commit d631c7d into frappe:develop Jul 13, 2023
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
@deepeshgarg007 @mergify
fix: Accounts closing balance patch (#36113)
90e5105 
(cherry picked from commit d631c7d)
@mergify mergify bot mentioned this pull request Jul 13, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request Jul 13, 2023
@mergify @deepeshgarg007
fix: Accounts closing balance patch (#36113)
cf29156 
fix: Accounts closing balance patch (#36113)

(cherry picked from commit d631c7d)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
mergify bot added a commit that referenced this pull request Jul 13, 2023
@mergify
fix: Accounts closing balance patch (#36113)
8894239 
fix: Accounts closing balance patch (#36113)

(cherry picked from commit d631c7d)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
(cherry picked from commit cf29156)
deepeshgarg007 pushed a commit that referenced this pull request Jul 13, 2023
@mergify
fix: Accounts closing balance patch (#36113)
49f28b0 
fix: Accounts closing balance patch (#36113)

fix: Accounts closing balance patch (#36113)

(cherry picked from commit d631c7d)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
(cherry picked from commit cf29156)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Jul 13, 2023
@frappe-bot
chore(release): Bumped to Version 14.30.2
1d9c28e 
## [14.30.2](v14.30.1...v14.30.2) (2023-07-13)

### Bug Fixes

* Accounts closing balance patch ([#36113](#36113)) ([49f28b0](49f28b0))
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
@frappe-bot
chore(release): Bumped to Version 14.31.0
22a19e4 
# [14.31.0](v14.30.7...v14.31.0) (2023-07-18)

### Bug Fixes

* `TypeError` while creating WO from PP (backport [#36136](#36136)) ([#36137](#36137)) ([dd51010](dd51010))
* Account balance patch and query fixes ([#36117](#36117)) ([0147754](0147754))
* Accounts closing balance patch ([#36113](#36113)) ([cf29156](cf29156))
* allow manual asset receipt mov from nowhere ([#36093](#36093)) ([4aaa1a1](4aaa1a1))
* Ambiguous column error while submitting stock entry ([#36058](#36058)) ([a3a052b](a3a052b))
* circular dependency during reposting causing timeout error ([2c21404](2c21404))
* get_dimension with_cost_center_and_project=false is not working ([#35974](#35974)) ([42c93a1](42c93a1))
* Handle multi-company in patch ([#36127](#36127)) ([e7f5754](e7f5754))
* improve "Update Items" modal ([#36105](#36105)) ([b86571d](b86571d))
* incorrect Balance Qty in the stock ledger for the item with Serial and Batch no ([373b868](373b868))
* incorrect Reserved Qty for Production Plan in BIN for multi-uom case ([2f632d0](2f632d0))
* Opening balance in TB report ([#36171](#36171)) ([313ad7a](313ad7a))
* Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([d10e5e6](d10e5e6))
* Remove current fiscal year from Global Defaults ([#35960](#35960)) ([b877fa6](b877fa6))
* Trailing opening entries in Accounts closing balance ([#36175](#36175)) ([8a607db](8a607db))
* validate docs in closed accounting period on save ([#36157](#36157)) ([5985e02](5985e02))

### Features

* add local holidays ([#36116](#36116)) ([94caf7f](94caf7f))
* add project filter in reports importing financial statements js file ([#36097](#36097)) ([63e26e3](63e26e3))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36144](#36144)) ([6198983](6198983))
* send SLA doctypes in boot ([adb6918](adb6918))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007